fix(studio): restore jsdom storage on Node 25 - #4476
Open
ranxi2001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make jsdom tests use Vitest's own
localStorageon Node 25, whose enabled-by-default Web Storage global otherwise prevents Vitest from exposing the complete jsdom implementation.Human Involvement
Related Issue
Part of #4471 (problem 1 of 2).
Type of Change
Changes Made
localStorageonly when Vitest exposes aJSDOMinstance; andjsdom.window.localStorageinstead of maintaining a Storage mock.Testing
Before, Node 25.8.2 failed exactly the three Playground storage tests:
After:
Focused Prettier and ESLint checks pass. Full
npm run lintstill reports the two unchangedtask-pipeline.tserrors tracked as #4471 problem 2; that fix is intentionally a separate PR.Checklist
Screenshots (if applicable)
Not applicable. This changes only the test environment and has no rendered UI output.
Additional Notes
The setup affects the 26 files that opt into jsdom. The remaining 30 test files stay in their existing Node environment because the setup is guarded by the presence of Vitest's
jsdomglobal.