Skip to content

fix(cache): bump Mooncake past ASan force-link - #4478

Open
ranxi2001 wants to merge 1 commit into
volcengine:mainfrom
ranxi2001:fix/mooncake-asan-pin
Open

fix(cache): bump Mooncake past ASan force-link#4478
ranxi2001 wants to merge 1 commit into
volcengine:mainfrom
ranxi2001:fix/mooncake-asan-pin

Conversation

@ranxi2001

Copy link
Copy Markdown
Contributor

Description

The pinned Mooncake revision force-linked its ASan runtime whenever the build toolchain
provided one. The resulting ragfs_python wheel carried a DT_NEEDED entry for a
bundled libasan, so loading it into a normal Python process aborted because ASan was
not first in the process library list.

This change moves all three Mooncake pins to upstream commit
8bfa404f9230db7010102e25e63f162fa4da8f12, which makes ASan linking opt-in through
MOONCAKE_LINK_ASAN and leaves it disabled for ordinary builds.

Human Involvement

  • A human participated in the implementation or review loop
  • This PR was generated entirely by AI agents without human participation in the loop

Related Issue

Part of #4468 (item 1 of 3).

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

  • bump the optional mooncake_store Rust dependency to the first non-force-linking revision;
  • build the Mooncake smoke image from that same revision; and
  • keep the provider README's documented pin synchronized.

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Before the bump:

NEEDED Shared library: [libasan-66dd4c48.so.6]
ragfs_python.libs/libasan-66dd4c48.so.6
ASan runtime does not come first in initial library list

After the bump:

readelf: no ASan dependency
wheel: no bundled libasan
import: ok

Additional Linux validation:

  • the fixed Docker image built successfully;
  • Mooncake's official Rust minimal_smoke passed against live metadata and master services;
  • OpenViking's native_mooncake_round_trips_complete_objects_over_tcp passed against those services;
  • all 8 non-native provider contract tests passed; and
  • git diff --check passed.

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Not applicable. This changes native dependency selection and has no rendered UI output.

Additional Notes

The selected Mooncake revision is 91 commits ahead of the old pin. The binding-facing
store.rs, store_c.h, Rust manifest, and lib.rs blobs are identical across the two
revisions, and the live smoke covers the integration boundary.

The repository's workspace-excluded -p/--locked smoke commands remain item 2 of
#4468 and are intentionally not changed here. For this verification, commands used the
crate manifest directly in a container-only source copy; no build workaround is part of
the PR diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant