fix(cache): bump Mooncake past ASan force-link - #4478
Open
ranxi2001 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pinned Mooncake revision force-linked its ASan runtime whenever the build toolchain
provided one. The resulting
ragfs_pythonwheel carried aDT_NEEDEDentry for abundled
libasan, so loading it into a normal Python process aborted because ASan wasnot first in the process library list.
This change moves all three Mooncake pins to upstream commit
8bfa404f9230db7010102e25e63f162fa4da8f12, which makes ASan linking opt-in throughMOONCAKE_LINK_ASANand leaves it disabled for ordinary builds.Human Involvement
Related Issue
Part of #4468 (item 1 of 3).
Type of Change
Changes Made
mooncake_storeRust dependency to the first non-force-linking revision;Testing
Before the bump:
After the bump:
Additional Linux validation:
minimal_smokepassed against live metadata and master services;native_mooncake_round_trips_complete_objects_over_tcppassed against those services;git diff --checkpassed.Checklist
Screenshots (if applicable)
Not applicable. This changes native dependency selection and has no rendered UI output.
Additional Notes
The selected Mooncake revision is 91 commits ahead of the old pin. The binding-facing
store.rs,store_c.h, Rust manifest, andlib.rsblobs are identical across the tworevisions, and the live smoke covers the integration boundary.
The repository's workspace-excluded
-p/--lockedsmoke commands remain item 2 of#4468 and are intentionally not changed here. For this verification, commands used the
crate manifest directly in a container-only source copy; no build workaround is part of
the PR diff.