fix(profiler): use correct attribute names in Profiler class #4723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Profiler class was using incorrect attribute names that don't exist in ProfilerConfig: 1. Changed `self.config.profile_ranks` to `self.config.ranks` - the ProfilerConfig dataclass uses `ranks`, not `profile_ranks` 2. Changed `self.config.step_start/step_end` to `self.tool_config.step_start/step_end` - these attributes exist on TorchProfilerToolConfig, not ProfilerConfig Fixes volcengine#4663 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes several AttributeError bugs in the Profiler class by using the correct attribute names from ProfilerConfig and TorchProfilerToolConfig. The changes are accurate and address the issues described. I've added one suggestion to improve the file path construction in the save method, making it more robust and platform-independent by using os.path.join instead of string concatenation.
vermouth1992
approved these changes
Dec 31, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
Profilerclass was using incorrect attribute names that don't exist inProfilerConfig:Changed
self.config.profile_rankstoself.config.ranks- theProfilerConfigdataclass usesranks, notprofile_ranksChanged
self.config.step_start/step_endtoself.tool_config.step_start/step_end- these attributes exist onTorchProfilerToolConfig, notProfilerConfigChanges
verl/utils/profiler/profile.py:59: Fixedprofile_ranks→ranksverl/utils/profiler/profile.py:79-81: Fixedprofile_ranks→ranksand condition checkverl/utils/profiler/profile.py:109: Fixedself.config.step_start/step_end→self.tool_config.step_start/step_endTest Plan
ProfilerConfigdefinition inconfig.pyTorchProfilerToolConfigcontainsstep_startandstep_endfieldsFixes #4663
🤖 Generated with Claude Code