Skip to content

Conversation

@RobotGF
Copy link
Contributor

@RobotGF RobotGF commented Dec 31, 2025

What does this PR do?

add logprob_mode config for vllm rollout. And set default rollout logprob mode "processed_logprobs" to return logprobs processed after temperature、Penalty、and topk topp

ref : vllm-project/vllm#22387

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a logprobs_mode configuration for vLLM rollouts, defaulting to processed_logprobs. The changes are correctly implemented across the YAML configuration, the dataclass definition, and the vLLM server arguments. However, I've identified a potential runtime error due to an incorrect type hint in the configuration dataclass which could prevent users from disabling this feature. My review includes a suggestion to fix this.

RobotGF and others added 2 commits December 31, 2025 17:06
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@vermouth1992 vermouth1992 merged commit 7a82f2e into volcengine:main Dec 31, 2025
68 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants