Skip to content

fix(install script)!: exit with non-zero exit code on error #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oscar-vitecenova wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(install script)!: exit with non-zero exit code on error #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions dev/unix/volta-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,17 @@ install_version() {
;;
esac

if [ "$?" == 0 ]
then
if [ "$should_run_setup" == "true" ]; then
info 'Finished' "installation. Updating user profile settings."
"$install_dir"/bin/volta setup
else
"$install_dir"/bin/volta --version &>/dev/null # creates the default shims
info 'Finished' "installation. No changes were made to user profile settings."
fi
local install_status="$?"
if [ "$install_status" -ne 0 ]; then
return "$install_status"
fi

if [ "$should_run_setup" == "true" ]; then
info 'Finished' "installation. Updating user profile settings."
"$install_dir"/bin/volta setup
else
"$install_dir"/bin/volta --version &>/dev/null # creates the default shims
info 'Finished' "installation. No changes were made to user profile settings."
fi
}

Expand Down