Skip to content

Delete unused queries from @volt_app.channel_live_queries #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mstate wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Delete unused queries from @volt_app.channel_live_queries #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5419f5
remove queries from channel_live_queries when they are no longer asso…
mstate Feb 29, 2016
97b4abc
checking if serialize errors are from this delete
mstate Feb 29, 2016
d97ee8f
can't do delete on the query object. instead loop through the channe…
mstate Feb 29, 2016
be023b8
return true when running remove listener to provide a return value th…
mstate Feb 29, 2016
214ab96
don't need to check for opal from the task
mstate Feb 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/volt/tasks/live_query/live_query.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Tracks a channel and a query on a collection. Alerts
# the listener when the data in the query changes.
class LiveQuery
attr_reader :current_ids, :collection, :query
attr_reader :current_ids, :collection, :query, :channels

def initialize(pool, data_store, collection, query)
@pool = pool
Expand Down
4 changes: 4 additions & 0 deletions app/volt/tasks/query_tasks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ def initial_data
def remove_listener(collection, query)
live_query = @volt_app.live_query_pool.lookup(collection, query)
live_query.remove_channel(@channel)

# If query has no more channels remove it from channel_live_queries
@volt_app.channel_live_queries[@channel].delete(live_query) if live_query.channels.blank?
return true
end

# Removes a channel from all associated live queries
Expand Down