Squeezelite 2.0.0 for Volumio 3.#222
Open
LarsGrootkarzijn wants to merge 3 commits intovolumio:masterfrom
Open
Squeezelite 2.0.0 for Volumio 3.#222LarsGrootkarzijn wants to merge 3 commits intovolumio:masterfrom
LarsGrootkarzijn wants to merge 3 commits intovolumio:masterfrom
Conversation
Contributor
Author
|
Should now be submitted aswell :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I recently fixed LMS, but there was no current stable Squeezelite plugin I decided to fix Sayato his Squeezelite plugin. I saw he earlier tried a pull request as well. Back then the following points were made which made the pull request unaccaptable:
Squeezelite not installing at all -> fixed
Did not use the Volumio 3 standard.
I fixed this by removing the ability of selecting an output device, and now just use the volumio output device. One thing I am not sure about is if these settings can stay or have to be removed as well:
The config file was not getting written -> fixed.
Potential fatal error when writing to config.json -> fixed.
Plugin is not yet submitted, but I made a request to @volumio via mail as I am not the original owner.