fix(spotify): fix unset volatile callback#287
Open
phts wants to merge 5 commits intovolumio:masterfrom
Open
Conversation
Owner
|
You're right, thanks for spotting it. Will require some testing which I'll do this week |
phts
force-pushed
the
spotify-fix-unset-volatile
branch
from
99909d6 to
26f667f
Compare
Contributor
Author
|
Added |
phts
force-pushed
the
spotify-fix-unset-volatile
branch
2 times, most recently
from
44d8290 to
df77e58
Compare
phts
force-pushed
the
spotify-fix-unset-volatile
branch
from
df77e58 to
d50e0a4
Compare
|
Any ETA on this @volumio ? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very suspicious line and most likely seems like a typo. Theoretically should be a reference to a function, instead of instantly calling it.
Probably this is the reason of some "connect" issues described in https://community.volumio.com/t/new-2023-spotify-plugin/63381
Not tested yet.
UPD
Exactly fixed problem with switching volatile mode by adding flag to ignore all events from spotify during switching from volatile mode to local mode. Spotify sends several "pause" events so it used to switch back to volatile mode.
Also added some refactoring related to this functionality.
Check my commits - they describe what changes they contain.