-
Notifications
You must be signed in to change notification settings - Fork 78
Bump libc to 0.2.171 to use sigaction for AIX #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello The changes look nice. However, you update the libc only in Cargo.lock ‒ which is only internal (for development) and downstream crates don't take it into account at all. Can you also mandate the right minimal libc in |
Thanks for pointing this out! Changed |
Gentle ping. We cannot build
|
LGTM from the AIX perspective |
Gentle ping... |
Sorry for late response, too little time… Released as 1.4.3. |
* Do not list the libc minimal version on signal-hook, the aix change that prompted it is for signal-hook-registry. * Do not force it for that one either. That would break our (arguably too conservative) minimal rust version. However, hint to the AIX user that upgrading their libc might be a good idea. * Also mention in docs that to actually compile the crate on such an ancient version of rust, they need to keep libc old too. See #169.
No worries, thanks so much! |
Change to use
sa_sigaction
instead ofsa_union.__su_sigaction
, now that thelibc
crate 0.2.171 implementation for AIX definessa_sigaction
as a direct member ofstruct sigaction
, aligning it with implementations on other similar platforms. (rust-lang/libc#4250).