Modification of attribute banner to fix issue with launching with qtconsole command #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #13 for original bug details.
Updated the PowerShellKernel to use the traitlets model for the attribute banner. I've never used traitlets before, but that what the underlining ipykernel.Kernel is structured off of and what qtconsole.base_frontend_mixin.BaseFrontendMixin's _dispatch() is expecting.
Implementation:
banner = Unicode()
Questions for @vors
Other comments:
--FrontendWidget.banner=...
now works, however this is the JupyterWidget(IPythonWidget)'s banner, not the kernel's banner.