Skip to content

Make ExecutionArgs a dyn trait#6715

Open
gatesn wants to merge 1 commit intodevelopfrom
ngates/execution-args
Open

Make ExecutionArgs a dyn trait#6715
gatesn wants to merge 1 commit intodevelopfrom
ngates/execution-args

Conversation

@gatesn
Copy link
Contributor

@gatesn gatesn commented Feb 27, 2026

This allows implementations to short-circuit, and supports the next change where ExecutionArgs::get will return a Columnar value.

Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn requested a review from joseph-isaacs February 27, 2026 18:11
@gatesn gatesn added the changelog/break A breaking API change label Feb 27, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 27, 2026

Merging this PR will improve performance by 18.36%

⚡ 1 improved benchmark
✅ 953 untouched benchmarks
⏩ 1466 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_opt_bool_canonical_into[(10, 1000)] 1.6 ms 1.4 ms +18.36%

Comparing ngates/execution-args (759beef) with develop (0abfb33)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn enabled auto-merge (squash) February 28, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant