Skip to content

rwlock instead of mutex around encoding ids#6720

Draft
danking wants to merge 1 commit intodevelopfrom
dk/rwlock-session
Draft

rwlock instead of mutex around encoding ids#6720
danking wants to merge 1 commit intodevelopfrom
dk/rwlock-session

Conversation

@danking
Copy link
Contributor

@danking danking commented Feb 28, 2026

Is this reasonable? I noticed it while staring at Spiral profiles.

Signed-off-by: Daniel King <dan@spiraldb.com>
@danking danking requested a review from gatesn February 28, 2026 05:03
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2026

Merging this PR will improve performance by 13.17%

⚡ 2 improved benchmarks
✅ 952 untouched benchmarks
⏩ 1466 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 501.1 ns 442.8 ns +13.17%
Simulation map_each[BufferMut<i32>, 128] 858.1 ns 770.6 ns +11.36%

Comparing dk/rwlock-session (e5dafff) with develop (e0ce169)

Open in CodSpeed

Footnotes

  1. 1466 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant