array tree layouts#8066
Open
onursatici wants to merge 1 commit into
Open
Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
Closed
Merging this PR will improve performance by 18.03%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
358.4 µs | 323.4 µs | +10.83% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
211.2 µs | 175.7 µs | +20.24% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
224.7 µs | 188.5 µs | +19.21% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
197.9 µs | 162 µs | +22.17% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/array-tree-layout-stacked (39bfedf) with os/array-serialise-columnar (93e517d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new layouts, array tree layout and array tree flat layout. Latter writes the array node into a vortex array instead of serialising it into a flatbuffer, and the former collects all these columnar array nodes and creates one segment from them and writes at the end of the file, before the zone maps.
This replaces inlining the array nodes as flatbuffers to the footer