fix grouped sum index for listview array#8255
Conversation
|
|
||
| if validity.value(offset) { | ||
| // validity is for the outer list view, so it must be indexed with `i` | ||
| if validity.value(i) { |
There was a problem hiding this comment.
I think a Mask iterator is far faster than value for every function
There was a problem hiding this comment.
Yea but I don't think we have that now. I can add one though separately
Merging this PR will degrade performance by 23.16%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
30.3 µs | 45.2 µs | -33.03% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
160.8 µs | 197 µs | -18.38% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
175.6 µs | 211.6 µs | -17.02% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/grouped-sum-index (49004bb) with develop (340d7be)
Summary
grouped sum fallback should index the groups correctly when summing