Skip to content

Support pack expressions through JNI#8266

Merged
AdamGS merged 1 commit into
developfrom
adamg/jni-pack
Jun 5, 2026
Merged

Support pack expressions through JNI#8266
AdamGS merged 1 commit into
developfrom
adamg/jni-pack

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds support for the pack expression through the JNI interface. Also ran spotless on the java bindings which moved some things around.

API Changes

Adds the matching function to the Java wrapper

Testing

basic test in the java bindings, also tested with our Iceberg work.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@codspeed-hq

codspeed-hq Bot commented Jun 5, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 3 regressed benchmarks
✅ 1494 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compare[15] 120.4 µs 146.4 µs -17.73%
Simulation compare[14] 118 µs 142.1 µs -16.94%
Simulation compare[13] 116.1 µs 138.4 µs -16.06%
Simulation chunked_bool_canonical_into[(1000, 10)] 46.6 µs 31.7 µs +47.25%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 213.2 µs 177.2 µs +20.37%
Simulation encode_varbin[(1000, 8)] 166.5 µs 145.5 µs +14.43%
Simulation encode_varbin[(1000, 4)] 165 µs 144.3 µs +14.34%
Simulation encode_varbin[(1000, 2)] 164.2 µs 143.7 µs +14.3%
Simulation encode_varbin[(1000, 32)] 171.3 µs 150.7 µs +13.69%
Simulation chunked_varbinview_canonical_into[(100, 100)] 309.6 µs 274.6 µs +12.72%
Simulation bitwise_not_vortex_buffer_mut[128] 275.3 ns 246.1 ns +11.85%
Simulation compare[5] 77.6 µs 70 µs +10.8%
Simulation encode_varbin[(1000, 512)] 226.4 µs 205.3 µs +10.29%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/jni-pack (e7ff194) with develop (1e29b32)

Open in CodSpeed

@AdamGS AdamGS merged commit f127357 into develop Jun 5, 2026
76 of 79 checks passed
@AdamGS AdamGS deleted the adamg/jni-pack branch June 5, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature lang/java Relates to the Vortex Java API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants