Skip to content

Use DUCKDB_SOURCE_DIR if supplied#8363

Merged
myrrc merged 1 commit into
developfrom
myrrc/duckdb-src-env
Jun 11, 2026
Merged

Use DUCKDB_SOURCE_DIR if supplied#8363
myrrc merged 1 commit into
developfrom
myrrc/duckdb-src-env

Conversation

@myrrc

@myrrc myrrc commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

If duckdb-vortex is supplied, don't attempt to download duckdb

Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc requested a review from a team June 11, 2026 14:58
@myrrc myrrc added changelog/feature A new feature changelog/ci and removed changelog/feature A new feature labels Jun 11, 2026
@myrrc myrrc enabled auto-merge (squash) June 11, 2026 14:59
@myrrc myrrc added the ext/duckdb Relates to the DuckDB integration label Jun 11, 2026
@myrrc myrrc requested a review from 0ax1 June 11, 2026 15:04
@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1530 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 161.8 µs 198.1 µs -18.31%
Simulation chunked_varbinview_canonical_into[(100, 100)] 308.5 µs 273.5 µs +12.8%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/duckdb-src-env (bdbe62f) with develop (eda4dd0)

Open in CodSpeed

@myrrc myrrc merged commit 82b24cd into develop Jun 11, 2026
76 of 80 checks passed
@myrrc myrrc deleted the myrrc/duckdb-src-env branch June 11, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/ci ext/duckdb Relates to the DuckDB integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants