Skip to content

Add f64 sum benchmarks#8367

Merged
robert3005 merged 1 commit into
developfrom
mitko/sum/f64-bench
Jun 11, 2026
Merged

Add f64 sum benchmarks#8367
robert3005 merged 1 commit into
developfrom
mitko/sum/f64-bench

Conversation

@dimitarvdimitrov

Copy link
Copy Markdown
Contributor

Adds f64 cases to the aggregate_sum and aggregate_grouped benchmarks in vortex-array, to establish a baseline before changing float summation to Kahan (Neumaier) compensated summation.

Add f64 cases to the aggregate_sum and aggregate_grouped benchmarks to
establish a baseline for upcoming float summation changes.

Signed-off-by: Dimitar Dimitrov <dimitar@spiraldb.com>
@dimitarvdimitrov dimitarvdimitrov added the changelog/skip Do not list PR in the changelog label Jun 11, 2026
@dimitarvdimitrov dimitarvdimitrov marked this pull request as ready for review June 11, 2026 15:31
@dimitarvdimitrov dimitarvdimitrov requested a review from a team June 11, 2026 15:31
@codspeed-hq

codspeed-hq Bot commented Jun 11, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 16.2%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 2 regressed benchmarks
✅ 1530 untouched benchmarks
🆕 4 new benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 161.8 µs 198 µs -18.25%
Simulation varbinview_large 113.3 µs 131.9 µs -14.1%
🆕 Simulation sum_f64_all_valid N/A 294.2 µs N/A
🆕 Simulation sum_f64_clustered_nulls N/A 553.3 µs N/A
🆕 Simulation sum_f64 N/A 711.9 µs N/A
🆕 Simulation sum_f64_nulls_clustered N/A 629.1 µs N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mitko/sum/f64-bench (4c8059c) with develop (eda4dd0)1

Open in CodSpeed

Footnotes

  1. No successful run was found on develop (82b24cd) during the generation of this report, so eda4dd0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@robert3005 robert3005 enabled auto-merge (squash) June 11, 2026 17:32
@robert3005 robert3005 merged commit 9383c35 into develop Jun 11, 2026
72 of 74 checks passed
@robert3005 robert3005 deleted the mitko/sum/f64-bench branch June 11, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants