utilize prebuilt stonefish image for simulator test#595
Merged
Conversation
Andeshog
commented
Oct 2, 2025
Contributor
- Uses prebuilt sf image to speed up the test setup (removed manual setup, and no fallback in this PR. If the latest docker images suddenly ceases to exist then we just fix it ig 🤷 )
- The rosbag being involved seems to have messed with the receival of the operation_mode topic, leading to DP not activating. Hence the recent fails. This PR publishes the topic 5 times to ensure it is received.
Comment out the installation of Stonefish in setup script.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage 18.77% 18.77%
=======================================
Files 38 38
Lines 2376 2376
Branches 426 426
=======================================
Hits 446 446
Misses 1815 1815
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Will officially close this issue vortexntnu/vortex-ci#92 |
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.