Skip to content

utilize prebuilt stonefish image for simulator test#595

Merged
Andeshog merged 6 commits into
mainfrom
test/verify-that-prebuilt-image-works
Oct 2, 2025
Merged

utilize prebuilt stonefish image for simulator test#595
Andeshog merged 6 commits into
mainfrom
test/verify-that-prebuilt-image-works

Conversation

@Andeshog

@Andeshog Andeshog commented Oct 2, 2025

Copy link
Copy Markdown
Contributor
  • Uses prebuilt sf image to speed up the test setup (removed manual setup, and no fallback in this PR. If the latest docker images suddenly ceases to exist then we just fix it ig 🤷 )
  • The rosbag being involved seems to have messed with the receival of the operation_mode topic, leading to DP not activating. Hence the recent fails. This PR publishes the topic 5 times to ensure it is received.

@Andeshog Andeshog requested a review from kluge7 October 2, 2025 13:44
@codecov

codecov Bot commented Oct 2, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.77%. Comparing base (49572cb) to head (9999c52).
⚠️ Report is 86 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   18.77%   18.77%           
=======================================
  Files          38       38           
  Lines        2376     2376           
  Branches      426      426           
=======================================
  Hits          446      446           
  Misses       1815     1815           
  Partials      115      115           
Flag Coverage Δ
unittests 18.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Andeshog

Andeshog commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

Will officially close this issue vortexntnu/vortex-ci#92

@kluge7 kluge7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andeshog Andeshog merged commit 1adb624 into main Oct 2, 2025
8 checks passed
@Andeshog Andeshog deleted the test/verify-that-prebuilt-image-works branch October 2, 2025 21:12
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants