removed default yaml file, added launch args for launching drone #717
Merged
Conversation
…er for simulator or physical drone
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
+ Coverage 38.26% 39.27% +1.01%
==========================================
Files 83 79 -4
Lines 6687 6520 -167
Branches 2481 2478 -3
==========================================
+ Hits 2559 2561 +2
+ Misses 3450 3281 -169
Partials 678 678
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
Is this PR supposed to remove the pid controller? |
jorgenfj
requested changes
May 18, 2026
| return drone, namespace | ||
|
|
||
|
|
||
| def declare_config_type_arg(default_config_type="sim"): |
Contributor
There was a problem hiding this comment.
I think it makes sense to make the default physical since then real world testing will be less prone to using the wrong config
Contributor
Author
There was a problem hiding this comment.
this is possible yes, but then all github tests will probably timeout and fail
Contributor
Author
Yes pid euler no worky worky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
may kill some of the tests, maybe have to do round 2 with claude for orca and nautilus dp tests