add units and standard_name #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example PR.
I run the script
og1_variables.pyto read in variables yaml fromyaml/draft_yaml. I note from the log output that the first input term "AD2CP_HEADING" is failing with an error message:So, I add units (taken from the related term P06 of the OG1 NVS entry for HEADING http://vocab.nerc.ac.uk/collection/OG1/current/HEADING/) and the standard name platform_orientation from the CF standard names table https://cfconventions.org/Data/cf-standard-names/current/build/cf-standard-name-table.html
I re-run the script, and now this term is approved and is output to
yaml/validated_yaml/og1_variables.yaml