Skip to content

Feature/success loaded event #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bachphuc
Copy link

Hi.

First, thank for great library. I always use this library for any react-native project.
But I see only error event and there's no success event, it's not enough for my project, I want to know when image loaded so I add success event for both android and ios to your library and hope this hope others.

Thank you so much
Regards

@vovkasm
Copy link
Owner

vovkasm commented Oct 10, 2017

Thank you! Very good. I need couple of days to tune the formatting and check it before merge. Again thank you very much!

@vovkasm
Copy link
Owner

vovkasm commented Dec 8, 2017

Sorry for long delay. Thank you! Merged to develop branch, with some changes.
I plan to rename onSuccess to onLoad before release to be more in line with original RN component, is it ok?

And another question, you send type property in onSuccess event with value cache when resource was loaded from cache (only for iOS). Do you really use this functional and for what? Because I think we can have better api for this information, but interested in any usecases...
And in case this property was not very useful, I'd prefer to not send it while...

@bachphuc
Copy link
Author

Hi, so sorry for late response. Yes, rename onSuccess to onLoad it's ok. I use type "cache" to know that it's loaded from cache or direct from uri (no cache), maybe it will be helpful for some case :D but not in my app . Only addition information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants