Skip to content

chore(integration): AS-696 address integration test flakes#392

Merged
afoley587 merged 1 commit into
release/v2.9.0from
afoley/as-696-integration-compose-flake
May 30, 2025
Merged

chore(integration): AS-696 address integration test flakes#392
afoley587 merged 1 commit into
release/v2.9.0from
afoley/as-696-integration-compose-flake

Conversation

@afoley587

Copy link
Copy Markdown
Contributor

Rationale

I've noticed recently that, as our packages get bigger, it takes them longer to start up. Let's make our tests less flakey by adding logging retries.

Changes

  • Adds the checkContainerLogsWithRetries function which re-attempts to get logs
  • Switches the original test implementation of get_logs with checkContainerLogsWithRetries

Checklist

  • This PR maintains parity between Docker Compose and Helm

Testing

@afoley587 afoley587 marked this pull request as ready for review May 30, 2025 16:21
@afoley587 afoley587 requested a review from a team as a code owner May 30, 2025 16:21

@findtopher findtopher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afoley587 afoley587 merged commit 52189a2 into release/v2.9.0 May 30, 2025
19 checks passed
@afoley587 afoley587 deleted the afoley/as-696-integration-compose-flake branch May 30, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants