Skip to content

chore(pre-release): AS-701 test pre-release charts#393

Merged
afoley587 merged 2 commits into
release/v2.9.0from
afoley/as-701-use-helm-latest
May 30, 2025
Merged

chore(pre-release): AS-701 test pre-release charts#393
afoley587 merged 2 commits into
release/v2.9.0from
afoley/as-701-use-helm-latest

Conversation

@afoley587

Copy link
Copy Markdown
Contributor

Rationale

In a prior PR, we had pinned helm versions in our pre-release flow to 3.17.3 because there was an issue with OCI/HTTPS repos. This appears to be fixed in 3.18.1. This PR will serve as additional testing to ensure that everything works as expected.

Changes

Removes the 3.17.3 pin on helm in the pre-release-internal-env workflow.

Checklist

  • This PR maintains parity between Docker Compose and Helm

Testing

### OLD

% helm version
version.BuildInfo{Version:"v3.18.0", GitCommit:"cc58e3f5a3aa615c6a86275e6f4444b5fdd3cc4e", GitTreeState:"clean", GoVersion:"go1.24.3"}
% gcloud auth print-access-token | helm registry login -u oauth2accesstoken --password-stdin "https://us-central1-docker.pkg.dev"
Error: invalid reference: invalid registry "https://us-central1-docker.pkg.dev"
alexanderfoley@Alexanders-MacBook-Pro fiftyone-teams-app-deploy % 

### NEW

% helm version
version.BuildInfo{Version:"v3.18.1", GitCommit:"f6f8700a539c18101509434f3b59e6a21402a1b2", GitTreeState:"clean", GoVersion:"go1.24.3"}
% gcloud auth print-access-token | helm registry login -u oauth2accesstoken --password-stdin "https://us-central1-docker.pkg.dev"
Login Succeeded

@afoley587 afoley587 requested a review from a team as a code owner May 30, 2025 18:31
findtopher
findtopher previously approved these changes May 30, 2025

@findtopher findtopher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this thing!

@findtopher findtopher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno, without the dummy change I feel like it's really risky....

LEEERRROOOYYYY JEEEENKIIIINSSSS

@afoley587 afoley587 merged commit 32f82af into release/v2.9.0 May 30, 2025
8 checks passed
@afoley587 afoley587 deleted the afoley/as-701-use-helm-latest branch May 30, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants