chore(helm): AS-711 remove support for old kubernetes versions#395
Merged
afoley587 merged 3 commits intoJun 10, 2025
Conversation
findtopher
previously approved these changes
Jun 9, 2025
findtopher
left a comment
Contributor
There was a problem hiding this comment.
seems like we could simplify our ingress template since we can now make the base assumption that we're > 1.19...
helm/fiftyone-teams-app/templates/ingress.yaml
3:{{- if and .Values.ingress.className (not (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion)) }}
8:{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
24: {{- if and .Values.ingress.className (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion) }}
48: {{- if semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion }}
52: {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
64: {{- if semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion }}
68: {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
83: {{- if semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion }}
87: {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
7 tasks
kevin-dimichel
left a comment
Contributor
There was a problem hiding this comment.
Might now be a good time to clean up other references to old k8s versions?
For example:
- https://github.com/voxel51/fiftyone-teams-app-deploy/blob/main/tests/unit/helm/ingress_test.go
-
- which will update the references in
README.mdandREADME.md.gotmlptoo
- which will update the references in
kevin-dimichel
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
As discussed, any Kubernetes version older than 1.30.0 is EOL and no longer supported by kubernetes. Cloud providers may support as far back as 1.27. For example, Google supports 1.27.
In my opinion, taking a stance that we support non-EOL kubernetes versions seems like a decent stance to take. I am open to discussions on the PR!
Changes
Moves our minimum version from 1.18 to 1.30 in accordance with the kubernetes release lifecycle.
Note
We will need to make a corresponding
voxel51/fiftyonePR as well to update deprecation.voxel51.com.Checklist
Testing
Docs only PR