Skip to content

chore(helm): AS-711 remove support for old kubernetes versions#395

Merged
afoley587 merged 3 commits into
release/v2.9.0from
afoley/as-711-deprecate-old-kubernetes
Jun 10, 2025
Merged

chore(helm): AS-711 remove support for old kubernetes versions#395
afoley587 merged 3 commits into
release/v2.9.0from
afoley/as-711-deprecate-old-kubernetes

Conversation

@afoley587

@afoley587 afoley587 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Rationale

As discussed, any Kubernetes version older than 1.30.0 is EOL and no longer supported by kubernetes. Cloud providers may support as far back as 1.27. For example, Google supports 1.27.

In my opinion, taking a stance that we support non-EOL kubernetes versions seems like a decent stance to take. I am open to discussions on the PR!

Changes

Moves our minimum version from 1.18 to 1.30 in accordance with the kubernetes release lifecycle.

Note

We will need to make a corresponding voxel51/fiftyone PR as well to update deprecation.voxel51.com.

Checklist

  • This PR maintains parity between Docker Compose and Helm

Testing

Docs only PR

@afoley587 afoley587 requested a review from a team as a code owner June 9, 2025 19:10
findtopher
findtopher previously approved these changes Jun 9, 2025

@findtopher findtopher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we could simplify our ingress template since we can now make the base assumption that we're > 1.19...

helm/fiftyone-teams-app/templates/ingress.yaml
3:{{- if and .Values.ingress.className (not (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion)) }}
8:{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
24:  {{- if and .Values.ingress.className (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion) }}
48:            {{- if semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion }}
52:              {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
64:            {{- if semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion }}
68:              {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
83:            {{- if semverCompare ">=1.18-0" $.Capabilities.KubeVersion.GitVersion }}
87:              {{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}

findtopher
findtopher previously approved these changes Jun 9, 2025

@findtopher findtopher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:thank_you:

🙇‍♂️

@kevin-dimichel kevin-dimichel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might now be a good time to clean up other references to old k8s versions?

For example:

@findtopher findtopher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@afoley587 afoley587 merged commit 016dd0f into release/v2.9.0 Jun 10, 2025
8 checks passed
@afoley587 afoley587 deleted the afoley/as-711-deprecate-old-kubernetes branch June 10, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants