chore(values): AS-728 update the FIFTYONE_APP_INSTALL_FIFTYONE_OVERRI…#398
Merged
Conversation
findtopher
approved these changes
Jun 23, 2025
findtopher
left a comment
findtopher
left a comment
Contributor
There was a problem hiding this comment.
There's a small argument to be made that we could document PYPI_INDEX_URL_ENV_KEY here, which just replaces the index-url argument and doesn't require you to continue to update the package version 🤷
This definitely needs to be fixed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…DE env var
Rationale
We had a typo env var in our example
values.yamlfile. TheFIFTYONE_APP_INSTALL_FIFTYONE_OVERRIDEis actually what overrides thepip installstring, theFIFTYONE_TEAMS_VERSION_OVERRIDEis shown in the footer.Changes
Checklist
Testing
Docs only.