Updating docker docs#402
Merged
Merged
Conversation
prernadh
requested review from
afoley587,
ehofesmann,
findtopher,
kevin-dimichel and
sherpan
prernadh
force-pushed
the
prerna/update-docker-docs
branch
from
5287ce3 to
fc11850
Compare
kevin-dimichel
left a comment
kevin-dimichel
left a comment
Contributor
There was a problem hiding this comment.
Please run and fix the pre-commit violations.
Embedding ordered list like prefixes in headings is a different convention. I'm not sure that it adds value over an ordered list. Especially when regular text includes a : that leads to the next heading.
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: prerna <163362853+prernadh@users.noreply.github.com>
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: prerna <163362853+prernadh@users.noreply.github.com>
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: prerna <163362853+prernadh@users.noreply.github.com>
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: prerna <163362853+prernadh@users.noreply.github.com>
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: prerna <163362853+prernadh@users.noreply.github.com>
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: prerna <163362853+prernadh@users.noreply.github.com>
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: prerna <163362853+prernadh@users.noreply.github.com>
Signed-off-by: prerna <163362853+prernadh@users.noreply.github.com>
findtopher
previously approved these changes
Jun 27, 2025
findtopher
left a comment
findtopher
left a comment
Contributor
There was a problem hiding this comment.
Now with more working links!
Looks good to me!
findtopher
previously approved these changes
Jun 30, 2025
findtopher
left a comment
findtopher
left a comment
Contributor
There was a problem hiding this comment.
This still looks fine to me, though it doesn't include parity with the Helm documentation.
Member
Author
@findtopher I haven't included anything new, just rewritten it and I will do that for Helm too. Just in a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Current docs needed a refresh. This first PR only tackles docker docs. Will have a subsequent PR for Helm docs.
Changes
Updating the README for docker deployments
Checklist
Testing
Locally previewed the md files.