Skip to content

fix: add driver-ops and docs warning#575

Closed
kaixi-wang wants to merge 2 commits into
alan/telemetry-including-redisfrom
release/v2.19.0-volume-ownership
Closed

fix: add driver-ops and docs warning#575
kaixi-wang wants to merge 2 commits into
alan/telemetry-including-redisfrom
release/v2.19.0-volume-ownership

Conversation

@kaixi-wang

Copy link
Copy Markdown
Member

Rationale

  • avoid permissions issues when the sidecar comes up due to ownership

Review Priority

  • high
  • medium
  • low

Changes

Checklist

  • This PR maintains parity between Docker Compose and Helm

Testing

@kaixi-wang kaixi-wang self-assigned this May 27, 2026
@kaixi-wang kaixi-wang requested a review from a team as a code owner May 27, 2026 18:23
@coderabbitai

coderabbitai Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • develop
  • release-*/

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d5fbd32a-d60f-4456-8f56-5de829adaaea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch release/v2.19.0-volume-ownership

Comment @coderabbitai help to get the list of available commands and usage tips.

…v2.19.0-rc.17 api:v2.19.0rc18 app:v2.19.0rc18 cas:v2.19.0-rc.17

@mo-getter mo-getter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there will be no existing root-owned telemetry volumes in customer envs, can you please remove all changes to the md files? Also, do we need the PYTHON_UNBUFFERED change? I think that could have a negative performance impact on workloads.

@kaixi-wang

Copy link
Copy Markdown
Member Author

I wasn't able to push changes to this branch since it starts with release/ so made changes on a new branch #576

@kaixi-wang kaixi-wang closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants