Skip to content

chore: update startup integration tests [HOLD UNTIL NEXT RELEASE]#579

Draft
kaixi-wang wants to merge 2 commits into
release/v2.20.0from
kacey/fix-flaky-api-log-tests
Draft

chore: update startup integration tests [HOLD UNTIL NEXT RELEASE]#579
kaixi-wang wants to merge 2 commits into
release/v2.20.0from
kacey/fix-flaky-api-log-tests

Conversation

@kaixi-wang
Copy link
Copy Markdown
Member

@kaixi-wang kaixi-wang commented May 30, 2026

Rationale

Review Priority

  • high
  • medium
  • low

Changes

Checklist

  • This PR maintains parity between Docker Compose and Helm

Testing

@kaixi-wang kaixi-wang self-assigned this May 30, 2026
@kaixi-wang kaixi-wang requested a review from a team as a code owner May 30, 2026 01:27
@kaixi-wang kaixi-wang marked this pull request as draft May 30, 2026 01:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 30, 2026

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4fde055b-8bba-4198-8c02-a2e6a454a871

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Five integration test files update expected container and pod log message assertions across Docker Compose and Helm deployment scenarios. Expected log patterns for teams-api and teams-cas services change from previous readiness/worker indicators to explicit startup messages.

Changes

Service startup log assertions

Layer / File(s) Summary
Docker Compose log assertions
tests/integration/compose/docker-compose-internal-auth_test.go, tests/integration/compose/docker-compose-legacy-auth_test.go
Docker Compose internal-auth and legacy-auth test cases across all compose modes (compose, composePlugins, composeDedicatedPlugins, composeDelegatedOperations) update expected log substrings from motd.py and ✓ Ready in to FiftyOne Teams API starting up and FiftyOne CAS starting up.
Helm pod log assertions
tests/integration/helm/helm-internal-auth_test.go, tests/integration/helm/helm-legacy-auth_test.go, tests/integration/helm/helm-topology-spread-constraint_test.go
Helm internal-auth, legacy-auth, and topology-spread-constraint test cases across plugin scenarios (builtinPlugins, sharedPlugins, dedicatedPlugins) update expected pod log values from readiness/worker-start patterns to FiftyOne CAS starting up and FiftyOne Teams API starting up.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • mo-getter

Poem

🐰 The tests now wake up fresh and bright,
With startup messages, shiny and right,
From compose to helm, they all agree—
FiftyOne's launching for all to see! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating integration test assertions for startup log messages across Docker Compose and Helm tests to match new CAS and API startup messages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description follows the template structure with Rationale, Review Priority (low selected), Changes checklist (Docker Compose/Helm parity confirmed), and Testing sections included.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kacey/fix-flaky-api-log-tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevin-dimichel
Copy link
Copy Markdown
Contributor

@kaixi-wang - while we are at it, can we update https://github.com/voxel51/fiftyone-teams/pull/2539 to be something more meaningful than { name: "John Doe" }? When we do, we can update the checks here too.

@kaixi-wang
Copy link
Copy Markdown
Member Author

https://github.com/voxel51/fiftyone-teams/pull/2788 for the teams-app

@kevin-dimichel kevin-dimichel changed the base branch from main to release/v2.20.0 June 3, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants