Skip to content

fix: increase telemetry-sidecar CPU#581

Merged
mo-getter merged 3 commits into
release/v2.20.0from
fix/telemetry-cpu-limit
Jun 5, 2026
Merged

fix: increase telemetry-sidecar CPU#581
mo-getter merged 3 commits into
release/v2.20.0from
fix/telemetry-cpu-limit

Conversation

@mo-getter

Copy link
Copy Markdown
Contributor

Rationale

We have observed that some of the telemetry-sidecar containers use near their full 100m cpu limit.

Credit: @kevin-dimichel

Review Priority

  • high
  • medium
  • low

Changes

  • docker compose: bump cpu reservation/limit to 200m for teams-plugins-telemetry-common
  • helm: bump all telemetry-sidecars to 200m
  • update docs accordingly

Checklist

  • This PR maintains parity between Docker Compose and Helm

Testing

Local helm template

helm: all sidecars 100 -> 200m cpu
docker: teams-plugins 100 -> 200m cpu

Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com>
@mo-getter mo-getter requested a review from a team as a code owner June 5, 2026 21:43
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Looking for one thing? Review this PR in Change Stack to search files, summaries, diffs, and code without losing your place.

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dd84b06b-dd73-49e3-9b06-faf0f938f14c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR updates telemetry sidecar resource documentation across Docker and Helm deployment targets. CPU request/limit values are increased from 100m to 200m per sidecar, default sidecar counts are adjusted, and resource impact totals are recalculated in deployment upgrade guides and Helm values documentation.

Changes

Telemetry Sidecar Resources

Layer / File(s) Summary
Telemetry sidecar resource requirements across deployment targets
docker/docs/upgrading.md, helm/docs/upgrading.md, helm/fiftyone-teams-app/README.md
Updated telemetry sidecar resource impact estimates across Docker and Helm documentation: per-sidecar CPU increased from 100m to 200m, default sidecar counts adjusted, and total CPU and memory impact recalculated in upgrade guides and values documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A sidecar feast with more muscle and might,
Two hundred millicores shining so bright,
Through Docker and Helm, the docs now align,
Resource requests refreshed—telemetry by design!
✨🚀

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: increasing telemetry-sidecar CPU allocations from 100m to 200m.
Description check ✅ Passed The PR description includes all required sections: rationale, changes, checklist for parity, and testing. All sections are adequately filled with relevant details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/telemetry-cpu-limit

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread docker/common-services.yaml
Comment thread helm/docs/upgrading.md Outdated
mo-getter and others added 2 commits June 5, 2026 18:24
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com>
Signed-off-by: Alan Smith <209585+mo-getter@users.noreply.github.com>
@mo-getter mo-getter requested a review from kevin-dimichel June 5, 2026 22:35
@mo-getter mo-getter merged commit 1e9ecb8 into release/v2.20.0 Jun 5, 2026
24 of 30 checks passed
@mo-getter mo-getter deleted the fix/telemetry-cpu-limit branch June 5, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants