feat(sidecar): support extraVolumes

[kaixi-wang]

Rationale

Apple requested that we support extraVolumes in the sidecar so they can mount the same certs as the other containers (https://voxel51.slack.com/archives/C0AJ8LW8P6H/p1782404775160409)
https://voxel51.atlassian.net/browse/FOEPD-4139

Review Priority

• high
• medium
• low

Changes

Checklist

• This PR maintains parity between Docker Compose and Helm

Testing

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6b4db4a4-efec-4427-98f2-63ca5b2f648a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

The Helm telemetry sidecar templates now append telemetry.sidecar.extraVolumeMounts to rendered mounts, and the README documents the new volume settings. Unit tests render multiple workloads and verify the added mounts and volumes.

Changes

Telemetry sidecar extra volumes

Layer / File(s)	Summary
Template rendering and values docs helm/fiftyone-teams-app/templates/_telemetry.tpl, helm/fiftyone-teams-app/README.md	telemetry.sidecar and telemetry.native-sidecar now build volumeMounts from a list that includes the socket mount plus telemetry.sidecar.extraVolumeMounts; the README adds telemetry.sidecar.extraVolumeMounts and telemetry.sidecar.extraVolumes.
Extra-volume tests tests/unit/helm/telemetry-sidecar_test.go	The telemetry sidecar test file adds helpers, a workload matrix, and a rendering test that checks extra mounts and volumes in the generated Deployment, including the executor-mode socket mount.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• voxel51/fiftyone-teams-app-deploy#566: Touches the same telemetry sidecar mount rendering path in templates/_telemetry.tpl and related tests.

Suggested reviewers

• kevin-dimichel

Poem

A rabbit hopped through Helm tonight,
To tuck new volumes snug and tight.
Sidecar mounts now weave and blend,
With socket paths that still կախ?
Thump-thump—deploys look just right.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	⚠️ Warning	The PR description matches the template headings but leaves Changes and Testing empty and does not select a review priority.	Fill in the Changes and Testing sections, select a review priority, and briefly describe how the sidecar extraVolumes change was validated.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: adding extra sidecar volumes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch kacey/telemetry-extravolumes

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/unit/helm/telemetry-sidecar_test.go`:
- Around line 51-67: The helpers hasVolumeMount and hasVolume should return the
matching VolumeMount/Volume instead of only a boolean, so the telemetry-sidecar
test can assert the rendered fields. Update the test to use these returned
values from hasVolumeMount and hasVolume to verify mountPath, readOnly, and the
volume’s secretName, rather than only checking that the names exist.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7cc0c92e-482b-4a43-866b-10c2e6b80def

📥 Commits

Reviewing files that changed from the base of the PR and between 711670f and d2789ab.

⛔ Files ignored due to path filters (7)

• helm/fiftyone-teams-app/templates/api-deployment.yaml is excluded by !**/*.yaml
• helm/fiftyone-teams-app/templates/app-deployment.yaml is excluded by !**/*.yaml
• helm/fiftyone-teams-app/templates/delegated-operator-instance-deployment.yaml is excluded by !**/*.yaml
• helm/fiftyone-teams-app/templates/delegated-operator-job-configmap.yaml is excluded by !**/*.yaml
• helm/fiftyone-teams-app/templates/plugins-deployment.yaml is excluded by !**/*.yaml
• helm/fiftyone-teams-app/values.schema.json is excluded by !**/*.json
• helm/fiftyone-teams-app/values.yaml is excluded by !**/*.yaml

📒 Files selected for processing (3)

• helm/fiftyone-teams-app/README.md
• helm/fiftyone-teams-app/templates/_telemetry.tpl
• tests/unit/helm/telemetry-sidecar_test.go