docs(docker): remove obsolete FIFTYONE_DATABASE_ADMIN=true install step#591
Conversation
The "set FIFTYONE_DATABASE_ADMIN=true on first install" procedure is obsolete as of v2.9+ (fiftyone core commit 44acde9a53, June 2024): a fresh database now initializes to the connecting client's version, so the admin gate never fires on a fresh install. Aligns Docker with Helm's existing v2.9 treatment; leaves the migration/upgrade safeguard section intact. Refs: AS-578 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughUpdates ChangesDocker README deployment instructions
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ding Fixes markdownlint MD051/link-fragments after renaming the Step 4 heading. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: Murilo Gustineli <52141042+mgustineli@users.noreply.github.com>
Co-authored-by: Kevin DiMichel <56850465+kevin-dimichel@users.noreply.github.com> Signed-off-by: Murilo Gustineli <52141042+mgustineli@users.noreply.github.com>
Apply markdownlint-fix (collapse double blank line) and markdown-toc (drop stale "Official Docker Images" TOC entry for the removed heading) so the pre-commit CI check passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kevin-dimichel
left a comment
There was a problem hiding this comment.
After #565 there are merge conflicts that need resolution.
…dme-database-admin-cleanup # Conflicts: # docker/README.md

Summary
Removes the obsolete install-time
FIFTYONE_DATABASE_ADMIN: trueguidance from the Docker deployment README and fixes the self-contradictory "Enable Database Admin mode" step, bringing Docker in line with Helm's existing v2.9+ treatment. The migration/upgrade safeguard section is left untouched.Motivation
Per AS-578 and the cs-aloha thread, the "set
FIFTYONE_DATABASE_ADMIN=trueon first install" procedure is obsolete as of v2.9+. It became unnecessary in fiftyone core commit voxel51/fiftyone@44acde9 (June 2024): a fresh database now initializes to the connecting client's version, so there's nothing to migrate and the admin gate never fires on a fresh install. Because this is corefiftyonebehavior shipped in the same images for both Helm and Docker, it applies to both — Helm's docs were already updated, but the Docker README lagged and even contradicted itself (Step 3 saidtrue # Only for first install, while Step 4 showedfalse).Changes (
docker/README.md)FIFTYONE_DATABASE_ADMIN: true # Only for first installfrom thecompose.override.yamlexample; fresh installs don't need it.falseunder an "enable" heading and claimedfalse"allows the application to create and migrate the database schema" (misleading). It now states admin mode isn't required for a fresh install (v2.9+), thatfalseis the safe default, and thattrueis only for intentional migrations (links to Upgrades).falseto prevent auto-migration + thefiftyone migratebehavior) is still correct.Test plan
fiftyonecore code (deployment-agnostic), confirmed via the commit history above (44acde9a53).Refs: AS-578 · voxel51/fiftyone@44acde9a53
🤖 Generated with Claude Code