Skip to content

add env vars to DO job templates and add tests#592

Merged
mo-getter merged 4 commits into
kacey/fix-k8-gpu-sidecar-detectionfrom
alan/nvidia-env-vars-add-tests-and-bump
Jun 30, 2026
Merged

add env vars to DO job templates and add tests#592
mo-getter merged 4 commits into
kacey/fix-k8-gpu-sidecar-detectionfrom
alan/nvidia-env-vars-add-tests-and-bump

Conversation

@mo-getter

Copy link
Copy Markdown
Contributor

Rationale

Builds upon #583, exposing the NVIDIA env vars in the on-demand job templates, and adds unit tests.

Review Priority

  • high
  • medium
  • low

Changes

Checklist

  • This PR maintains parity between Docker Compose and Helm

Testing

make test-unit-helm

@mo-getter mo-getter requested a review from a team as a code owner June 30, 2026 15:14
@mo-getter mo-getter added the priority-high High Priority PR - review immediately label Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • develop
  • release-*/

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0fe3c9fe-258b-4835-b93a-49853399c493

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch alan/nvidia-env-vars-add-tests-and-bump

Comment @coderabbitai help to get the list of available commands.

@mo-getter mo-getter merged commit 43341ef into kacey/fix-k8-gpu-sidecar-detection Jun 30, 2026
3 checks passed
@mo-getter mo-getter deleted the alan/nvidia-env-vars-add-tests-and-bump branch June 30, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority-high High Priority PR - review immediately

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants