Skip to content

fix: api log line test flakes race condition#594

Closed
mo-getter wants to merge 1 commit into
mainfrom
fix/api-log-test-flakes
Closed

fix: api log line test flakes race condition#594
mo-getter wants to merge 1 commit into
mainfrom
fix/api-log-test-flakes

Conversation

@mo-getter

@mo-getter mo-getter commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Rationale

API log line tests are still flaking.

Review Priority

  • high
  • medium
  • low

Changes

  • sets PYTHONUNBUFFERED=1
  • widens the log-assertion retry budget in checkContainerLogsWithRetries

Checklist

  • This PR maintains parity between Docker Compose and Helm

Testing

Will see in CI.

@mo-getter mo-getter requested a review from a team as a code owner July 1, 2026 14:41
@mo-getter mo-getter added the priority-high High Priority PR - review immediately label Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The retry policy in the compose integration test's log-checking helper was adjusted to allow more retries and longer delays between attempts, with added comments explaining the rationale for the increased time budget.

Changes

Compose Log Retry Tuning

Layer / File(s) Summary
Update retry count and delay
tests/integration/compose/common_test.go
checkContainerLogsWithRetries retry configuration increased from 6 retries/2s delay to 15 retries/3s delay, with comments documenting the added headroom.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit waits with patient care,
Fifteen tries, more time to spare,
Three seconds pass, logs finally bloom,
No more flakes in the compose room! 🐰⏱️

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the core change: reducing flaky API log line tests by adjusting buffering and retry behavior.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description follows the template with rationale, priority, changes, checklist, and testing sections filled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/api-log-test-flakes

Comment @coderabbitai help to get the list of available commands.

@mo-getter mo-getter removed the priority-high High Priority PR - review immediately label Jul 1, 2026
@mo-getter mo-getter marked this pull request as draft July 1, 2026 14:45
@mo-getter mo-getter marked this pull request as ready for review July 1, 2026 14:52
Base automatically changed from release/v2.21.0 to main July 1, 2026 15:56
@mo-getter

Copy link
Copy Markdown
Contributor Author

Closing for now, as we will be exploring a different approach.

@mo-getter mo-getter closed this Jul 6, 2026
@mo-getter mo-getter deleted the fix/api-log-test-flakes branch July 6, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant