feat: unified orchestrator templates#604
Open
mo-getter wants to merge 6 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Force-skip helm-unit and helm-integration and let helm-pre-release accept skipped results so every PR push still publishes the fiftyone-teams-app sha chart for ephemeral environment testing. DO NOT MERGE — revert before this branch lands in main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… anyway" This reverts commit e1a095d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
FiftyOne is adding service-based orchestrators (kubernetes-service environment: long-lived, on-demand service pods) alongside the existing job-based delegated operators, and deployments need to configure both. youcef/service-orchestrator-chart built the foundations for this — the service pod template, the orchestrator-seeding Job, and the builtin-services overrides — as a parallel configuration surface (its own ConfigMaps, values trees, and a hand-authored orchestrator registration list).
This PR lands that functionality unified under the existing delegatedOperatorJobTemplates pattern instead, so operators configure job- and service-based orchestrators one way, and the chart diff against main stays as small and reviewable as possible.
Review Priority
Changes
Upgrade note: deployments with existing jobs entries will seed registrations named after those entries on first upgrade (idempotent upserts after). Opt out with template.registerOrchestrator: false.
Checklist
Testing
Note
Ephem testing in progress.