Skip to content
This repository was archived by the owner on Sep 4, 2025. It is now read-only.

Fixed "The set-output command is deprecated and will be disabled soon" alert#82

Open
vitalykarasik wants to merge 8 commits into
voxmedia:mainfrom
FlexCharge:main
Open

Fixed "The set-output command is deprecated and will be disabled soon" alert#82
vitalykarasik wants to merge 8 commits into
voxmedia:mainfrom
FlexCharge:main

Conversation

@vitalykarasik

Copy link
Copy Markdown

Purpose

Fixed "The set-output command is deprecated and will be disabled soon" alert.
See #71

Important Changes

Bumped @actions/core to 1.10.0

@jacob-briscoe jacob-briscoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitalykarasik shouldn't the following set-output usage in ci.yml be updated as well to fully resolve this issue?

.github/workflows/ci.yml#L30

@vitalykarasik

Copy link
Copy Markdown
Author

@jacob-briscoe - thank you, makes sense, fixed.
BTW, I updated GHA versions as well.
Vitaly

@jacob-briscoe jacob-briscoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! Nice job.

We'll need a maintainer to approve this change.

@multiplegeorges

Copy link
Copy Markdown

Came to find this, thanks for taking the initiative and getting it done.

Can we get this merged, @ebinmore ? This is a really useful action!

@csaba-kovacs

Copy link
Copy Markdown

Anyone?

@rietta

rietta commented Feb 24, 2023

Copy link
Copy Markdown

This looks good and is a simple update that follows GitHub recommendations. It should be merged soon since GitHub has announced the deprecated functionality will be disabled soon.

@aariacarterweir

Copy link
Copy Markdown

Can we get this merged please? 😄

@chrisbodhi

Copy link
Copy Markdown

Thanks for getting this started! We use this action in many of our workflows, and getting it updated will be useful for us.

Taking a quick look at the PR, it looks like there's both a yarn.lock file and a package-lock.json file. On the current main branch, there's only a yarn.lock. It seems that the package-lock.json is extraneous, and can be safely removed.

@csaba-kovacs

Copy link
Copy Markdown

Should we wait for this or the message is clear and this repo is abandoned?

@alexandre-perrin

alexandre-perrin commented Apr 27, 2023

Copy link
Copy Markdown

Should we wait for this or the message is clear and this repo is abandoned?

@csaba-kovacs I'm confused about your comment. Is this repo supposed to be abandoned?

Edit: Oh I see what you meant... 4 months without response, I didn't see it was open for so long.

@jybaek

jybaek commented Apr 27, 2023

Copy link
Copy Markdown

@ebinmore set-output will soon be deprecated in GitHub Actions. If you have access to the repository here, could you please merge it?

@csaba-kovacs

csaba-kovacs commented Apr 27, 2023

Copy link
Copy Markdown

Should we wait for this or the message is clear and this repo is abandoned?

@csaba-kovacs I'm confused about your comment. Is this repo supposed to be abandoned?

Edit: Oh I see what you meant... 4 months without response, I didn't see it was open for so long.
@alexandre-perrin
#69 (comment)

@aldenquimby

aldenquimby commented Apr 28, 2023

Copy link
Copy Markdown

This repo is abandoned: #69 (comment)

Anyone here will to establish themselves as the primary fork moving forward?

@justinr636

Copy link
Copy Markdown

@aldenquimby I can't commit to any further maintenance, but I applied the changes in this PR to my forked branch and published it here: https://github.com/marketplace/actions/gha-slack-notify-build

@MohamedAsan

Copy link
Copy Markdown

Hi @vitalykarasik, is there any published version with recent changes in which you have upgraded the node version? If so, can you kindly share the link or the action name that I should use?

@justinr636 Can you also copy the changes and publish a latest version in this action? We are getting deprecation notice for node v16

@vitalykarasik

Copy link
Copy Markdown
Author

Hi @vitalykarasik, is there any published version with recent changes in which you have upgraded the node version? If so, can you kindly share the link or the action name that I should use?

@MohamedAsan
My fork is now open, but I suggest not using it because we'll make it private soon.

@csaba-kovacs

Copy link
Copy Markdown

You can use mine. I did the upgrade.

@MohamedAsan

MohamedAsan commented Feb 25, 2024

Copy link
Copy Markdown

@csaba-kovacs Awesome, thanks a lot 💪

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.