Skip to content

Drop profiles::certbot requires that duplicate Package[certbot] #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miharp wants to merge 2 commits into
base: production
Choose a base branch
from
+5 −2
Open

Drop profiles::certbot requires that duplicate Package[certbot] #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97bb52f
Drop profiles::certbot requires that duplicate Package[certbot]
miharp Aug 14, 2026
a448688
Gemfile: add rexml for the libvirt provider
miharp Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions site/profiles/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,7 @@ puppetversion = ENV['PUPPET_GEM_VERSION'] || '>= 8.19'
gem 'metadata_json_deps', require: false
gem 'openvox', puppetversion, require: false, groups: [:test]
gem 'syslog'
# rexml left the Ruby stdlib like syslog did; the libvirt module's
# virsh provider requires it, so specs need it in the bundle
gem 'rexml'
# vim: syntax=ruby
3 changes: 2 additions & 1 deletion site/profiles/manifests/grafana.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
) {
require profiles::base
$domain = "grafana.${facts['networking']['fqdn']}"
# certbot comes with the letsencrypt class that profiles::nginx pulls
# in; requiring profiles::certbot too duplicates Package[certbot]
require profiles::nginx
require profiles::certbot
require profiles::postgresql
require profiles::postfix
package { 'toml':
Expand Down
1 change: 0 additions & 1 deletion site/profiles/manifests/postfix.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
class profiles::postfix {
# provides /etc/ssl/certs/ca-certificates.crt for smtpd_tls_CAfile ini_setting
require profiles::base
require profiles::certbot
# todo: use puppet/postfix
package { 'postfix':
ensure => 'installed',
Expand Down