Optimize: Skip module resolution if Puppetfile matches upstream#243
Open
xorpaul wants to merge 7 commits into
Open
Optimize: Skip module resolution if Puppetfile matches upstream#243xorpaul wants to merge 7 commits into
xorpaul wants to merge 7 commits into
Conversation
When updating a control repository, if the Puppetfile in the upstream commit is identical to the one currently deployed, we can skip the expensive module resolution and extraction steps. This change: 1. Calculates SHA256 checksums of the deployed Puppetfile and the upstream Puppetfile content (retrieved via git show). 2. Signals a match via the needSyncEnvs map. 3. Checks this signal in resolvePuppetfile() to bypass module processing unless -force is used. This significantly speeds up deployments where only control repository content (like manifests or hiera data) changes but module dependencies remain static. Fixes #233
Reinitialize uniqueForgeModules map at the start of resolvePuppetfile() alongside the existing latestForgeModules reinitialization. Without this, ForgeModule entries (including baseURL from httptest servers) persisted across calls, causing subsequent resolvePuppetfile invocations to reuse stale Forge URLs and fail with connection refused errors. Also removes stale commented-out debug prints. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The unbuffered done channel could deadlock when goroutines complete before the collector goroutine starts reading. Buffering it to len(modules) ensures sends never block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When a deploy result signature already matches the current commit, set the PuppetfileMatch flag so resolvePuppetfile can skip redundant module resolution for unchanged environments. Fix three tests affected by this optimization: - TestLastCheckedFile: use force=true so Forge cache files are written even when deploy artifacts from prior runs exist - TestPurgeStalePuppetfileOnly: reset needSyncEnvs between consecutive resolvePuppetEnvironment calls so purge logic runs on the second call - TestEnvironmentParameter: use force=true in subprocess to bypass stale deploy artifacts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests that the PuppetfileMatch optimization correctly skips module resolution on the second run when the Puppetfile content hasn't changed. Sets up a local git control repo with a Puppetfile, deploys it, then verifies the skip message appears on re-deployment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Covers all releases from v0.1.0 (2016-01-04) through v0.9.11-alpha (2025-11-06) using Keep a Changelog format with categorized entries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Documents build commands, architecture, global state pitfalls, testing patterns (subprocess pattern, state pollution), and the PuppetfileMatch optimization for AI-assisted development. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating a control repository, if the Puppetfile in the upstream commit is identical to the one currently deployed, we can skip the expensive module resolution and extraction steps.
This change:
This significantly speeds up deployments where only control repository content (like manifests or hiera data) changes but module dependencies remain static.
Fixes #233