Make rspec-puppet rake task configureable#74
Open
bastelfreak wants to merge 1 commit into
Open
Conversation
By default, we use the parallel_spec task. Some modules might have tests that call out to external APIs, where tests need to be run sequentially, not in parallel (e.g. puppet-vault_hiera).
ekohl
requested changes
Apr 15, 2025
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
I'd prefer to keep this generic so I opened voxpupuli/puppet-hiera_vault#105 to avoid the need for this. By starting multiple vault servers on unique ports we should be able to run in parallel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, we use the parallel_spec task. Some modules might have tests that call out to external APIs, where tests need to be run sequentially, not in parallel (e.g. puppet-vault_hiera).
Required for voxpupuli/puppet-hiera_vault#100