Skip to content

fix: 'fatal error: concurrent map read and map write' crash #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastianrakel merged 1 commit into from
Mar 17, 2026
Merged

fix: 'fatal error: concurrent map read and map write' crash #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 60 additions & 52 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"flag"
"fmt"
"log"
"sync"

"github.com/sebastianrakel/openvoxview/model"
"github.com/spf13/viper"
Expand Down Expand Up @@ -58,59 +59,66 @@ func PrintVersion(version string) bool {
return false
}

func GetConfig() (*Config, error) {
viper.SetConfigName("config")
viper.SetConfigType("yaml")
viper.AddConfigPath(".")

if configPath != nil {
log.Printf("Using config: %s", *configPath)
viper.SetConfigFile(*configPath)
}
var (
cachedConfig *Config
cachedErr error
configOnce sync.Once
)

viper.SetDefault("port", 5000)
viper.SetDefault("puppetdb.host", "localhost")
viper.SetDefault("puppetdb.port", 8080)
viper.SetDefault("puppetdb.tls_ignore", false)
viper.SetDefault("unreported_hours", 3)
viper.SetDefault("puppetca.port", 8140)
viper.SetDefault("puppetca.tls", true)
viper.SetDefault("puppetca.tls_ignore", false)
viper.SetDefault("puppetca.readonly", true)
viper.SetDefault("puppetca.deactivate_nodes", false)

viper.AutomaticEnv()

viper.BindEnv("port", "PORT")
viper.BindEnv("listen", "LISTEN")
viper.BindEnv("trusted_proxies", "TRUSTED_PROXIES")
viper.BindEnv("puppetdb.port", "PUPPETDB_PORT")
viper.BindEnv("puppetdb.host", "PUPPETDB_HOST")
viper.BindEnv("puppetdb.tls", "PUPPETDB_TLS")
viper.BindEnv("puppetdb.tls_ignore", "PUPPETDB_TLS_IGNORE")
viper.BindEnv("puppetdb.tls_ca", "PUPPETDB_TLS_CA")
viper.BindEnv("puppetdb.tls_key", "PUPPETDB_TLS_KEY")
viper.BindEnv("puppetdb.tls_cert", "PUPPETDB_TLS_CERT")
viper.BindEnv("unreported_hours", "UNREPORTED_HOURS")
viper.BindEnv("puppetca.host", "PUPPETCA_HOST")
viper.BindEnv("puppetca.port", "PUPPETCA_PORT")
viper.BindEnv("puppetca.tls", "PUPPETCA_TLS")
viper.BindEnv("puppetca.tls_ignore", "PUPPETCA_TLS_IGNORE")
viper.BindEnv("puppetca.tls_ca", "PUPPETCA_TLS_CA")
viper.BindEnv("puppetca.tls_key", "PUPPETCA_TLS_KEY")
viper.BindEnv("puppetca.tls_cert", "PUPPETCA_TLS_CERT")
viper.BindEnv("puppetca.readonly", "PUPPETCA_READONLY")
viper.BindEnv("puppetca.deactivate_nodes", "PUPPETCA_DEACTIVATE_NODES")

viper.ReadInConfig()

var cfg Config

err := viper.Unmarshal(&cfg)

cfg.TrustedProxies = viper.GetStringSlice("trusted_proxies")

return &cfg, err
func GetConfig() (*Config, error) {
configOnce.Do(func() {
viper.SetConfigName("config")
viper.SetConfigType("yaml")
viper.AddConfigPath(".")

if configPath != nil {
log.Printf("Using config: %s", *configPath)
viper.SetConfigFile(*configPath)
}

viper.SetDefault("port", 5000)
viper.SetDefault("puppetdb.host", "localhost")
viper.SetDefault("puppetdb.port", 8080)
viper.SetDefault("puppetdb.tls_ignore", false)
viper.SetDefault("unreported_hours", 3)
viper.SetDefault("puppetca.port", 8140)
viper.SetDefault("puppetca.tls", true)
viper.SetDefault("puppetca.tls_ignore", false)
viper.SetDefault("puppetca.readonly", true)
viper.SetDefault("puppetca.deactivate_nodes", false)

viper.AutomaticEnv()

viper.BindEnv("port", "PORT")
viper.BindEnv("listen", "LISTEN")
viper.BindEnv("trusted_proxies", "TRUSTED_PROXIES")
viper.BindEnv("puppetdb.port", "PUPPETDB_PORT")
viper.BindEnv("puppetdb.host", "PUPPETDB_HOST")
viper.BindEnv("puppetdb.tls", "PUPPETDB_TLS")
viper.BindEnv("puppetdb.tls_ignore", "PUPPETDB_TLS_IGNORE")
viper.BindEnv("puppetdb.tls_ca", "PUPPETDB_TLS_CA")
viper.BindEnv("puppetdb.tls_key", "PUPPETDB_TLS_KEY")
viper.BindEnv("puppetdb.tls_cert", "PUPPETDB_TLS_CERT")
viper.BindEnv("unreported_hours", "UNREPORTED_HOURS")
viper.BindEnv("puppetca.host", "PUPPETCA_HOST")
viper.BindEnv("puppetca.port", "PUPPETCA_PORT")
viper.BindEnv("puppetca.tls", "PUPPETCA_TLS")
viper.BindEnv("puppetca.tls_ignore", "PUPPETCA_TLS_IGNORE")
viper.BindEnv("puppetca.tls_ca", "PUPPETCA_TLS_CA")
viper.BindEnv("puppetca.tls_key", "PUPPETCA_TLS_KEY")
viper.BindEnv("puppetca.tls_cert", "PUPPETCA_TLS_CERT")
viper.BindEnv("puppetca.readonly", "PUPPETCA_READONLY")
viper.BindEnv("puppetca.deactivate_nodes", "PUPPETCA_DEACTIVATE_NODES")

viper.ReadInConfig()

var cfg Config
cachedErr = viper.Unmarshal(&cfg)
cfg.TrustedProxies = viper.GetStringSlice("trusted_proxies")
cachedConfig = &cfg
})

return cachedConfig, cachedErr
}

func (c *Config) GetPuppetDbAddress() string {
Expand Down