Add hash expansion of existing types #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Sep 1, 2025
Once the main class has been included:
```puppet
include augeasproviders_ssh
````
type instances can be loaded from hiera data, for example:
```yaml
augeasproviders_ssh::sshd_configs:
AllowAgentForwarding:
ensure: 'present'
value: 'yes',
PermitRootLogin:
ensure: 'present'
value: 'yes'
```
Contributor
Author
|
Well the easy fix to the CI is #115 |
Contributor
Author
|
Tests fixed but only by adding an unused hiera.yaml file ? |
ekohl
reviewed
Sep 1, 2025
spec/spec_helper.rb
Outdated
|
|
||
| RSpec.configure do |c| | ||
| c.facterdb_string_keys = false | ||
| c.hiera_config = '' |
Member
There was a problem hiding this comment.
Makes me wonder if rspec-puppet itself should deal better with this. Relevant code: https://github.com/OpenVoxProject/openvox/blob/f70dd2111bed0be3ede7017c062df0edceb4ccd0/lib/puppet/indirector/hiera.rb#L80-L92
Contributor
Author
There was a problem hiding this comment.
I don't see the problem at all running locally with rspec.
Contributor
Author
There was a problem hiding this comment.
Empty string resulted in:
[#<Puppet::Util::Log:0x00007f117c545ff8 @level=:err, @tags=#<Puppet::Util::TagSet: {"err"}>, @message="Evaluation Error: Error while evaluating a Function Call, Is a directory @ io_fread - /home/runner/work/puppet-augeasproviders_ssh/puppet-augeasproviders_ssh", @source="Puppet", @time=2025-09-01 14:46:11.80255521 +0000, @line=2, @pos=1, @issue_code=:RUNTIME_ERROR, @node="pkrvmccyg1gnepe.h0l24wjbi32ehma3ntfoutcuxb.cx.internal.cloudapp.net">,
so that's a no.
Contributor
Author
There was a problem hiding this comment.
The "workaround" is now just a setting a for a hiera file that does not exist at all. Have added the .sync.yml to keep it there.
This is fairly resolved for me.
Without this v5 hiera yaml file: ``` + #<Puppet::Util::Log:0x00007f1ed6e6f298 @Level=:warning, @tags=#<Puppet::Util::TagSet: {"warning"}>, @message="/dev/null: File exists but does not contain a valid YAML hash. Falling back to Hiera version 3 default config", @source="Puppet", @time=2025-09-01 12:40:08.763493772 +0000>, + #<Puppet::Util::Log:0x00007f1ed6e6f1a8 @Level=:warning, @tags=#<Puppet::Util::TagSet: {"warning"}>, @message="/dev/null: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5\n (file: /dev/null)", @source="Puppet", @time=2025-09-01 12:40:08.763558543 +0000>, ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request (PR) fixes the following issues
Once the main class has been included:
include augeasproviders_sshtype instances can be loaded from hiera data, for example: