Manage storage directories after intallation#206
Merged
Conversation
Contributor
|
Hm I think a spec-test for that would be nice, there are no tests at all for this defined resource yet |
When creating a storage directory, we want to set correct ownership for it but before the bacula-sd package is installed, the bacula user and group may not be available, resulting in a catalog application failure. Explicitly require the storage daemon package to make sure the user/group are available when the directory is created. While here, add some basic testing for this class.
smortex
force-pushed
the
storage-device-ordering
branch
from
January 5, 2026 03:56
aa544e1 to
6d2a8c0
Compare
Member
Author
|
This was long overdue 😄
Testing specifically for the right value is a pain (because they are os-dependant), but having tests we are sure that the value is valid (i.e. required resources actually exist in the catalog), so I just added basic tests [almost] without parameters and with all parameters set. This allowed to see a bunch of inconsistencies, which are marked as FIXME as they are beyond the scope of this PR. |
TheMeier
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a storage directory, we want to set correct ownership for
it but before the bacula-sd package is installed, the bacula user and
group may not be available, resulting in a catalog appliaction failure.
Explicitly require the storage daemon package to make sure the
user/group are available when the directory is created.