Add Console section to the Director configuration#210
Merged
Conversation
smortex
reviewed
Jun 13, 2024
smortex
left a comment
smortex
left a comment
Member
There was a problem hiding this comment.
Looks good. I added some inline notes for review. Also it would be great to rebase on top of master to get rid of this merge commit.
lemrouch
force-pushed
the
director-console
branch
3 times, most recently
from
June 19, 2024 11:15
5c87f03 to
e29c622
Compare
smortex
force-pushed
the
director-console
branch
3 times, most recently
from
June 20, 2024 00:04
b623b58 to
fa8ff5a
Compare
smortex
reviewed
Jun 20, 2024
smortex
left a comment
smortex
left a comment
Member
There was a problem hiding this comment.
I added a few commit in your branch to "hide" the complex data type away from the console code, and add a basic unit test.
Are you happy with these changes?
Also, I added some in-line comments regarding quoting.
smortex
self-requested a review
June 21, 2024 08:46
smortex
approved these changes
Jun 21, 2024
smortex
force-pushed
the
director-console
branch
from
January 5, 2026 02:57
67e2b5d to
dbdfe95
Compare
Member
|
This was unexpectedly forgotten. I rebased it on top of master to make sure CI is still happy, let's merge this so that the next release ship it! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to add Console sections to the Director configuration. This is useful if one needs to force ACL for example for monitoring purposes.
This is done via define of a new collected resource
bacula::director::console.I found out that the CatalogACL and CommandACL need to be defined as the bare minimum to get anything working. Other parameters are therefore optional.