Add support for DNS Service record configuration #236
Conversation
|
|
||
| ### Use DNS Service records for dynamic NTP configuration | ||
|
|
||
| You can configure chrony to use DNS Service records for dynamic NTP server discovery. |
There was a problem hiding this comment.
TIL. Didn't know chrony supports this.
| $safe_name = regsubst($srv_record, '[^a-zA-Z0-9_-]', '_', 'G') | ||
| # Use actual srv_record for filenames | ||
| $sources_file = "${sourcedir}/${srv_record}.sources" | ||
| $script_file = "${sourcedir}/${srv_record}.sh" |
There was a problem hiding this comment.
I wonder if this will be executable on systems with SELinux enforcing (EL variants).
There was a problem hiding this comment.
what can we do about that?
There was a problem hiding this comment.
I suppose an acceptance test would be the way, but that might be a lot of work. I guess someone who actually uses this feature on SELinux could figure it out.
There was a problem hiding this comment.
could probably set seltype on the file, and have an acceptance test that sets this up using the .invalid TLD, then run the script. The lookup will fail, but the script should succeed
There was a problem hiding this comment.
Not sure if the acceptance test is worth it. Maybe seltype would be enough?
bwitt
force-pushed
the
add_srv_records
branch
from
21eafdc to
e45b1ef
Compare
bwitt
force-pushed
the
add_srv_records
branch
2 times, most recently
from
cd84716 to
a6b0ad4
Compare
kenyon
left a comment
kenyon
left a comment
There was a problem hiding this comment.
Just some removal of redundant comments where the code is self-explanatory.
bwitt
force-pushed
the
add_srv_records
branch
from
a6b0ad4 to
7977c54
Compare
3 participants
Pull Request (PR) description
Add support for reconfiguration via DNS SRV records.
This Pull Request (PR) fixes the following issues
Fixes #131