actually use unwrapped config_hash value

[kBite]

Sensitive support was added 2022 with #614, but somehow nobody noticed yet. Passing $config_hash as Sensitive[Hash] fails ...

Internal Server Error: org.jruby.exceptions.RuntimeError: (PreformattedError) Evaluation Error: Error while evaluating a Function Call, deep_merge: unexpected argument type Puppet::Pops::Types::PSensitiveType::Sensitive, only expects hash arguments

... because $config_hash_real does not actually use the unwrapped config_hash value.

[TheMeier]

A small test case for that would be nice for the future, would have caught that issue if it did exist.

[kBite]

I was searching instructions for how to run tests before. Now I found them: puppet-consul/.github/CONTRIBUTING.md.

Why are they in .github/ and not module root?

[kBite]

@TheMeier The test covers the Internal Server Error: described above. Running the same test against the master branch results in (e.g.)

  10) consul on almalinux-9-x86_64 When passing "config_hash" as Sensitive is expected to compile into a catalogue without dependency cycles
      Failure/Error: it { is_expected.to compile.with_all_deps }
        error during compilation: Evaluation Error: Error while evaluating a Function Call, deep_merge: unexpected argument type Puppet::Pops::Types::PSensitiveType::Sen
        sitive, only expects hash arguments (file: /tmp/puppet-consul/spec/fixtures/modules/consul/manifests/init.pp, line: 161, column: 23) on node localhost

[maxadamo]

It looks good to me

[kBite]

Thanks