Support custom arguments #11

recid · 2025-07-02T11:43:05Z

Add a default value for Grafana Alloy APT key Id
Adapt the repo class to use it

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

* Add hiera structure (datadir and yaml file) to improve the module * Add a default value for Grafana Alloy APT key Id (data/os/Debian.yaml) * Adapt the repo class to use it * Add a default value for apt_key_id ({ default_value => '' })

recid · 2025-07-02T13:58:45Z

Hi,
Even if some checks failed (timeout, docker image seems not available (Ubuntu 24:04)), do you validate my PR ?

If yes could you tell me when the new release will be available on the puppet forge please ?

Thanks in advance

manifests/repo.pp

* Update the repo class to make $apt_key_id variable optional * Change the apt_key_id scope * grafana_alloy::repo::apt_key_id instead of grafana_alloy::apt_key_id

recid · 2025-07-03T10:01:44Z

Finally, the more I use the module, the more I add some features that were necessary for me to configure Grafana Alloy.
I think it was my last updates :-)

If the PR was ok for you @ekohl , could you validate it and tell me when my modifications will be available on puppet forge ?

Thanks in advance

* Update the README.md in accordance with the feature

ekohl · 2025-07-03T15:59:10Z

If the PR was ok for you @ekohl , could you validate it

I don't even know what the original issue is. You only described what you did, not why. This means I can't validate it.

tell me when my modifications will be available on puppet forge

When it is merged a release needs to be made. That is documented in https://voxpupuli.org/docs/releasing_version/.

recid · 2025-07-10T11:21:02Z

Hello @ekohl , in fact I did this PR because I use puppet 5 (v5.5.22) with some old version of grafana_alloy dependencies such as apt (v7.0.0) and I can't upgrade the puppet version.

ekohl · 2025-07-10T11:43:05Z

I'm not opposed to introducing the class parameter without a default so you can work around it in your own infrastructure, but would like to avoid us having to maintain the GPG key ID unless there's a good reason, but Puppet 5 isn't a good reason. We don't support Puppet 5 anymore, nor apt 7.0. Our metadata states we only support Puppet 7+ and puppetlabs/apt 9.2+.

* Remove unnecessary apt_key_id variable (grafana_alloy::repo)

recid · 2025-07-11T13:49:26Z

I understand what you said.
So I updated the PR keeping only the changes concerning the Readme, the fact of overloading the custom-args option.

puppetlabs/apt 9.2+. brings new feature especially the apt gpg keyring management by name instead of by id.
I think this is that new feature that makes it no longer necessary to specify the gpg-key id into apt::key declaration

So I remove the hiera.yaml file and the data directory too.

ekohl

Thanks. I've updated the PR title to reflect the change.

README.md

manifests/config.pp

ekohl · 2025-07-11T15:16:39Z

README.md

+If you want to adapt the Alloy configuration you can use the `config` variable like this (into hiera declaration file):
+
+```puppet
+grafana_alloy::config:


grafana_alloy::config is a private API so documenting it as the primary usage doesn't look like the best idea. Perhaps better to expose it in init.pp as a real parameter?

manifests/config.pp

* Support RedHat customization (to specify CUSTOM_ARGS)

@example

* Add @example sections to describe how you can use grafana_alloy and its sub-classes

* Add REFERENCE.md file * Update the README.md to refer REFERENCE.md file and remove obsolete comments

recid · 2025-07-31T11:47:46Z

Hello @ekohl , thx again and a lot for your feedback.
I fix all your comments. So I thinks the PR will be ok to merge :)

* bundle exec rake strings:generate:reference

* Change the way to support Multiple OS when specify CUSTOM_ARGS env variable

salomon94 · 2025-09-02T13:25:01Z

Hello @ekohl , thx again and a lot for your feedback. I fix all your comments. So I thinks the PR will be ok to merge :)

Hello @recid do you have any news about it?

salomon94 · 2025-09-02T13:27:43Z

Hello @ekohl , thx again and a lot for your feedback. I fix all your comments. So I thinks the PR will be ok to merge :)

Hello @recid do you have any news about it?

Hello @ekohl the PR from @recid is ok?

n1nj444 · 2025-09-03T09:31:50Z

Hi, I have the same issue, can it be merged please ? cc @ekohl

evgeni · 2025-10-08T17:20:53Z

manifests/init.pp

+# @example If you want to pass arguments to the run commands, you can add the following content into your hieradata file:
+#   class { 'grafana_alloy::config':


This is a private class, so either you make a full hiera example here, or make the class non-private, or expose custom_args from init.pp.

recid force-pushed the fix_debian_installation branch 2 times, most recently from f067719 to 5558686 Compare July 2, 2025 11:59

fix: Fix the Debian Installation

7ac5e8e

* Add hiera structure (datadir and yaml file) to improve the module * Add a default value for Grafana Alloy APT key Id (data/os/Debian.yaml) * Adapt the repo class to use it * Add a default value for apt_key_id ({ default_value => '' })

recid force-pushed the fix_debian_installation branch from 5558686 to 7ac5e8e Compare July 2, 2025 12:45

ekohl reviewed Jul 2, 2025

View reviewed changes

manifests/repo.pp Outdated Show resolved Hide resolved

recid added 2 commits July 2, 2025 19:02

fix: Update some files around apt_key_id variable

db6145f

* Update the repo class to make $apt_key_id variable optional * Change the apt_key_id scope * grafana_alloy::repo::apt_key_id instead of grafana_alloy::apt_key_id

docs: Update the README.md file

858caff

feat: Pass some argument to the run commands (Debian)

c101abd

* Update the README.md in accordance with the feature

recid force-pushed the fix_debian_installation branch from b6f4c75 to c101abd Compare July 3, 2025 10:07

recid closed this Jul 11, 2025

recid deleted the fix_debian_installation branch July 11, 2025 13:46

Remove unnecessary hiera files

4cb126e

* Remove unnecessary apt_key_id variable (grafana_alloy::repo)

recid restored the fix_debian_installation branch July 11, 2025 13:49

recid reopened this Jul 11, 2025

ekohl changed the title ~~fix: Fix the Debian Installation~~ Support custom arguments Jul 11, 2025

ekohl reviewed Jul 11, 2025

View reviewed changes

ekohl added the enhancement New feature or request label Jul 11, 2025

recid added 3 commits July 31, 2025 13:19

Fix the manifests/config.pp file

0973c3c

* Support RedHat customization (to specify CUSTOM_ARGS)

Fix the manifests/init.pp

7e4e7df

* Add @example sections to describe how you can use grafana_alloy and its sub-classes

Improve documentation

f15427e

* Add REFERENCE.md file * Update the README.md to refer REFERENCE.md file and remove obsolete comments

Update REFERENCE.md after puppet-strings

efdbe4b

* bundle exec rake strings:generate:reference

recid force-pushed the fix_debian_installation branch from e0f7989 to 21d1d07 Compare July 31, 2025 12:08

Add a default value for environment path file

cc5a949

recid force-pushed the fix_debian_installation branch 2 times, most recently from 4704dbd to 2d4c49a Compare July 31, 2025 12:23

Fix the manifests/config.pp file

612d85e

* Change the way to support Multiple OS when specify CUSTOM_ARGS env variable

recid force-pushed the fix_debian_installation branch from 2d4c49a to 612d85e Compare July 31, 2025 12:24

recid added 2 commits July 31, 2025 14:31

Add Ubuntu case into $env_file

be6da16

Fix REFERENCE.md and manifests/init.pp files

d718799

evgeni reviewed Oct 8, 2025

View reviewed changes

		# @example If you want to pass arguments to the run commands, you can add the following content into your hieradata file:
		# class { 'grafana_alloy::config':

Uh oh!

Support custom arguments #11

Are you sure you want to change the base?

Support custom arguments #11

Uh oh!

Conversation

recid commented Jul 2, 2025

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Uh oh!

recid commented Jul 2, 2025

Uh oh!

Uh oh!

recid commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ekohl commented Jul 3, 2025

Uh oh!

recid commented Jul 10, 2025

Uh oh!

ekohl commented Jul 10, 2025

Uh oh!

recid commented Jul 11, 2025

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ekohl Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

recid commented Jul 31, 2025

Uh oh!

salomon94 commented Sep 2, 2025

Uh oh!

salomon94 commented Sep 2, 2025

Uh oh!

n1nj444 commented Sep 3, 2025

Uh oh!

evgeni Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

recid commented Jul 3, 2025 •

edited

Loading