Use apt::keyring and update GPG key, with modulesync changes#1143
Open
griggi-ws wants to merge 8 commits into
Open
Use apt::keyring and update GPG key, with modulesync changes#1143griggi-ws wants to merge 8 commits into
griggi-ws wants to merge 8 commits into
Conversation
Verifying the APT key fingerprint should really be a responsibility of
the `puppetlabs-apt` module, so we deliberately choose to not do it
here.
Note that, currenlty, neither the (obsolete) `apt::key` nor the
`apt::keyring` resources do key fingerprint verification, so this change
isn't really a regression. Here's an upstream issue:
puppetlabs/puppetlabs-apt#1175
Before this change, the key fingerprint was only used (by `apt::key`) to
name the file where the key was stored. Because no verification is made
either here or on the `puppetlabs-apt` side, we also remove the
`$gpg_key_id` class param. This change avoids the need to maintain the
hardcoded fingerprint, while also avoiding a false impression that they
fingerprint is somehow verified.
Discussion: voxpupuli#1130
use apt::keyring to install the Jenkins APT repo key in Debian
Co-authored-by: Mihmet Akpinar <mihmet.akpinar@check24.de>
…ether `java` binary exists in the test environment
griggi-ws
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This implements #1130, #1140, and #1141.
I've regenerated the rubocop todo alongside the modulesync changes, as prior to them rubocop passes and the updates result in lots of new warnings (and the lack of the GPG update renders this module useless as-is).
There's additionally a new stub to fix the cli_spec test, as it currently passes or fails depending on whether the test environment has a
javabinary in PATH. This will fix the CI run failure on #1142.This Pull Request (PR) fixes the following issues
Fixes #1129