Skip to content

Add oracle test that fails with current code - #469

Closed
Joris29 wants to merge 2 commits into
voxpupuli:masterfrom
Joris29:oracle_test
Closed

Add oracle test that fails with current code#469
Joris29 wants to merge 2 commits into
voxpupuli:masterfrom
Joris29:oracle_test

Conversation

@Joris29

@Joris29 Joris29 commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

<

@Joris29
Joris29 marked this pull request as draft November 21, 2025 14:00
@Joris29
Joris29 force-pushed the oracle_test branch 4 times, most recently from 661061c to 0208f3e Compare November 21, 2025 14:56
@Joris29

Joris29 commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

The issue seems to come from the pick:
pick($jira::dburl, $jira::db ? { ... }

I guess it still tries the selector here and the selector tries to use an unknown variable.

@Joris29 Joris29 changed the title Oracle test Add oracle test that fails with current code Nov 26, 2025
@Joris29
Joris29 marked this pull request as ready for review November 26, 2025 16:15
@kenyon

kenyon commented Nov 26, 2025

Copy link
Copy Markdown
Member

Needs a rebase to fix the conflict.

@Joris29

Joris29 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

Not sure what happend i thought this one was supposed to be merged before this one (#466) to actually test the broken code

@kenyon

kenyon commented Nov 26, 2025

Copy link
Copy Markdown
Member

@Joris29 yes, @bastelfreak may have missed this PR, but it's probably still good to get this test into the code.

@Joris29

Joris29 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

Not sure this test is relevant as i can't reproduce this error now with the other PR merged.

@kenyon

kenyon commented Nov 26, 2025

Copy link
Copy Markdown
Member

Yes, but maybe this kind of test still has value in avoiding regressions?

@Joris29

Joris29 commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

I'll try to take a look on adding more tests where needed with different databases types and difference between url and just dbserver, ... to avoid regression

@Joris29
Joris29 marked this pull request as draft November 26, 2025 21:52
@Joris29

Joris29 commented Nov 27, 2025

Copy link
Copy Markdown
Contributor Author

I'll close this in favor of another PR that will test different databases and different scenarios.

@Joris29 Joris29 closed this Nov 27, 2025
@Joris29
Joris29 deleted the oracle_test branch November 27, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants