Resync bundled resources to modern versions #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can this be considered backwards-incompatible? |
|
Right, hadn't actually committed all of the actually backwards-incompatible change, the one that drops support for Kubernetes < 1.23 Apart from that one, the new configuration should still work with the old versions if someone's pinned the tags for them, most of it is just restructuring to keep the Puppet definitions in line with upstream. |
|
ah okay, thats what i wanted to know: if the structure also works with older pinned versions. if yes, i consider this NOT as backwards-incompatible 😄 |
rwaffen
approved these changes
Mar 28, 2025
|
any reason this is being held up? |
|
nope, can/will merge this. just was thinking @ananace would merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This bumps all the bundled components to modern and supported versions, though it doesn't track the absolute latest for Kubernetes itself.
It also drops some workarounds for thoroughly EOL versions of K8s.
This Pull Request (PR) fixes the following issues