Improve handling of manage_* parameters#121
Merged
rwaffen merged 1 commit intovoxpupuli:masterfrom Mar 27, 2025
Merged
Conversation
Will no longer break catalog compilation and/or application when turning off manage_* parameters, and also respects them more Also removes a no longer required jq call from kubelet bootstrap, modern kubernetes can do non-raw output with an unauthenticated user
6c3019d to
4680dcc
Compare
rwaffen
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Will no longer break catalog compilation and/or application when turning off
manage_*parameters, and also respects them moreThis Pull Request (PR) fixes the following issues