Match the indent for a single semicolon with the Puppet documentation#48
Merged
alexjfisher merged 2 commits intovoxpupuli:mainfrom Aug 5, 2025
Merged
Match the indent for a single semicolon with the Puppet documentation#48alexjfisher merged 2 commits intovoxpupuli:mainfrom
alexjfisher merged 2 commits intovoxpupuli:mainfrom
Conversation
Member
|
The file {
default:
ensure => file,
owner => "root",
group => "wheel",
mode => "0600",
;
}It should be wanting 2 chars, not 4. |
Member
|
More tests you can pull in in 93b09f5 |
Contributor
Author
|
Fixed bug with incorrect indent when fixing semicolon at start of line and added @alexjfisher's tests. |
Replaces existing fail cases
alexjfisher
reviewed
Aug 5, 2025
| @@ -1,4 +1,7 @@ | |||
| require 'spec_helper' | |||
| # rubocop:disable Lint/RedundantRequireStatement | |||
| require 'pp' | |||
Member
There was a problem hiding this comment.
alexjfisher
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the handling of indent on the semicolon separator in resource statements so it matches the Puppet documentation example:
https://www.puppet.com/docs/puppet/7/lang_resources#resource-declaration-default-attributes
Fixes #19
Example from Puppet docs:
Currently the plugin expects this to be indented like this: